Add validations to AddTeam component's form

leusgalvan / fixture

App for making tournament fixtures

4 stars 2 forks source link

Add validations to AddTeam component's form #24

Open leusgalvan opened 5 years ago

leusgalvan commented 5 years ago

A team currently consists of:

name: string
members: array of {userId: string, displayName: String}

The AddTeam component, reachable at /team/add, displays a form with a simple text field for the name and a list to select members (users) by clicking them.

There are currently no validations whatsoever for that form. Some could be:

Don't allow empty names
Don't allow names with more than, say, 64 characters.
Force to choose at least one member (user).

Simonpedro commented 5 years ago

I would really recommend to take under consideration yup to do that task. Maybe in conjunction with Formik. Although yup should be enough.

leusgalvan commented 5 years ago

Sure, I'll try to learn how to use it. Do you think it will be easy to use with material-ui?

Simonpedro commented 5 years ago

Sure, I'll try to learn how to use it. Do you think it will be easy to use with material-ui?

Sure. It is just a light validation library.