level12 / copier-py-package

0 stars 0 forks source link

Ruff formatter conflicting lint rules #13

Closed rsyring closed 1 month ago

rsyring commented 4 months ago

Background: https://docs.astral.sh/ruff/formatter/#conflicting-lint-rules

Our ruff config ignores most of the rules listed on that page that end up being redundant. It leaves the following potentially conflicting rules in place:

because I think implicit string concatenation is too easy to miss when scanning code. I'd prefer concatenation to always be explicit.

There is a discussion going on regarding implicit string concatenation and how to remove the conflict: https://github.com/astral-sh/ruff/issues/8272

Trailing Commas

Explanation and discussion at: https://github.com/astral-sh/ruff/issues/9216#1774

I'd prefer to keep COM812 as an active rule and just do a double save when it shows up. I've done this in the past and it's slightly annoying but acceptable IMO. I could see how others would find this very annoying and be resistant. So, do you care either way?

rsyring commented 4 months ago

I've also not ignored line-too-long because I think that's something worth fixing manually if the linter and formatter can't get it squared away for us.

All of these decisions have been made in the context of these assumptions:

calebsyring commented 4 months ago

The double-save doesn't bother me too intensely. I'm frequently reflexively hitting ctrl+s, so I probably won't notice most of the time.

matthiaswh commented 4 months ago

I have a strong preference for COM812.

rsyring commented 1 month ago

Sounds like we are good with the current config