search

level12 / keg-app-cookiecutter

0 stars 0 forks source link

remove GridAssertions and FormBase #141

Closed guruofgentoo closed 3 years ago

guruofgentoo commented 3 years ago

GridAssertions now has a counterpart directly in webgrid (GridBase). FormBase is now in KegElements.

rsyring commented 3 years ago

@guruofgentoo I was going to remove GridAssertions, but it has a number of methods on it that webgrid testing utils don't seem to have. In particular, the tests here the CC use .assert_grid_matches(...). Am I missing something or is a refactoring necessary?

guruofgentoo commented 3 years ago

We had a couple of sets of assertion methods going back a ways, so not all the methods made the cut when there were duplicate concepts. I'd expect assert_grid_matches to be pretty close to expect_table_header and expect_table_contents.