search

leveldown-security / SVD-Loader-Ghidra

GNU General Public License v3.0
450 stars 91 forks source link

Fix import error on Ghidra 9.1 AddMemoryBlockCmd vs AddInitializedMem #3

Closed brainstorm closed 4 years ago

brainstorm commented 4 years ago

So that both 9.0 and 9.1 Ghidras are happy.

Fixes issue #2

brainstorm commented 4 years ago

Hm, caution merging this PR, more testing might be needed since none of the Labels are not being found post SVD-loader run and subsequent analysis:

Skärmavbild 2019-10-06 kl 19 20 11

Still unsure if those are tied to my firmware particularities or something else, so thorough testing before merging is highly advised! ;)

brainstorm commented 4 years ago

The concern above seems to be related with the IC I'm looking and its memory mapping.

SVD Peripheral refs like USB/SPI/GPIO seem to make sense in the decompiler, so I'd say it's safe-ish to merge ;)

nezza commented 4 years ago

That import turned out to be unused - I've comitted a fix to master though! Thanks!