search

levelgraph / levelgraph-n3

LevelGraph plugin for storing N3/Turtle/RDF data
36 stars 8 forks source link

updated dependencies #6

Closed elf-pavlik closed 10 years ago

elf-pavlik commented 10 years ago

should I also rename join() and joinStream() to search() and searchStream() ?

mcollina commented 10 years ago

Go ahead and merge, you have the commit bit!

elf-pavlik commented 10 years ago

@mcollina once I know what exactly I can s/join/search/ then I'll do it and merge. afterwards you can release newer version of this one as well :smile:

mcollina commented 10 years ago

please, do s/join/search :)

elf-pavlik commented 10 years ago

renaming done!

how do we go about deprecating augmented db.join() replaced by augmented db.search()? could we maybe keep everything N3 related under db.n3 -> db.n3.search()? also i still need to take a closer look how you do this, especially thinking of using multiple extensions N3 + JSONLD + ...

mcollina commented 10 years ago

The renaming is coded in a way such that if you just augment db.search it should work with db.join, but check ;).

I'm open to namespacing, too. I think it's better and it will avoid us problems later, so go for it!

elf-pavlik commented 10 years ago

changing db.search() to db.join() in search_spec.js fails! changing db.searchStream() to db.joinStream() in searchStream_spec.js fails!

still both give nice deprecation warnings when used :smile:

I'll look at keeping it namespaced...

BTW I should have created feature branch for this one here... first though that will just bump few dependencies :confused:

elf-pavlik commented 10 years ago

i think about merging those few changes here and after that creating v0.4.0-wip branch to work on changing the way we do N3 specific searches?

mcollina commented 10 years ago

I'm ok with this. If you want to 'kill' the search feature for materialiazed N3, go for it. We'll reintroduce it back when we need it.

mcollina commented 10 years ago

Is this ready for release? ;)

elf-pavlik commented 10 years ago

after #7 which looks like it will break current API...