search

leviFrosty / jw-time

A powerful field service assistant that puts user experience first.
Other
8 stars 1 forks source link

[FEATURE/BUG] Annual Goal Setting Toggle #95

Closed marlonsabala closed 3 months ago

marlonsabala commented 3 months ago

Describe the bug In the monthly report page, the yearly bar should be hidden for special pioneers in my opinion. It does not apply to them.

What do you think?

leviFrosty commented 3 months ago

Hi @marlonsabala again,

Thanks for catching this. As I don't have contacts with a special pioneer, some of these details are hard to get 100% correct.

Does this apply to all special pioneers?

Regardless, I'll create an 'Annual Goal' toggle for the onboarding and preferences sections that will allow you to say "Yes" or "No" to having an annual goal. Although the default for a publisher type should be the most applicable to everyone, this should make it easy for people to change things to their liking and not hard-lock different publisher types into a certain setting that might not apply to them.

Thanks, Levi!

marlonsabala commented 3 months ago

Hi Levi,

I think that is an excellent solution. And yes, it does apply to all special pioneers. They have a monthly goal only.

Thanks On 26 Mar 2024 at 15:11 +0000, Levi Wilkerson @.***>, wrote:

Hi @marlonsabala again, Thanks for catching this. As I don't have contacts with a special pioneer, some of these details are hard to get 100% correct. Does this apply to all special pioneers? Regardless, I'll create an 'Annual Goal' toggle for the onboarding and preferences sections that will allow you to say "Yes" or "No" to having an annual goal. Although the default for a publisher type should be the most applicable to everyone, this should make it easy for people to change things to their liking and not hard-lock different publisher types into a certain setting that might not apply to them. Thanks, Levi! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

leviFrosty commented 3 months ago

Hello again @marlonsabala,

96ff8d822a08470d9decf06193a79e21a0c7d8ca and d35f1752a505bbf42cad4d5d57eb87c8f4befd49 adds these changes that we discussed earlier.

You will see this fix and new feature in the next release :)

Thank you for pointing out some improvements that could be made. I will close this ticket now.

Best, Levi

marlonsabala commented 3 months ago

Fantastic stuff. Thanks Levi

Marlon Sabala On 29 Mar 2024 at 21:04 +0000, Levi Wilkerson @.***>, wrote:

Hello again @marlonsabala, 96ff8d8 and d35f175 adds these changes that we discussed earlier. You will see this fix and new feature in the next release :) Thank you for pointing out some improvements that could be made. I will close this ticket now. Best, Levi — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>