levid / angular-sails-socketio-mongo-demo

AngularJS, SailsJS, Socket.io & MongoDB Demo
170 stars 50 forks source link

Remove node_modules from repository #2

Closed anissen closed 10 years ago

anissen commented 11 years ago

The node_modules directory should not be included as it is generated via "npm install". Additionally, it adds ~21 MB (!) to the repo size.

While you're cleaning up the repo please remove the .gitkeep-files from non-empty directories.

jteneycke commented 11 years ago

I purged the folder from my fork (following http://dalibornasevic.com/posts/2-permanently-remove-files-and-folders-from-a-git-repository), but after I pushed the changes and tried to make a pull request, github told me:

There isn't anything to compare.

levid:master and jteneycke:master are entirely different commit histories.
levid commented 10 years ago

Thanks for the heads up, I have removed the node_modules directory and also the .gitkeep files. The master branch is now updated. Sorry about that!