levinli303 / astroweather-localization

0 stars 1 forks source link

Apple-specific suggestions #12

Closed Askaniy closed 1 year ago

Askaniy commented 1 year ago

I'm not even have Apple devices to test localization, but here are some notes:

levinli303 commented 1 year ago
  1. fair, i will change it
  2. please try to use iPhone/iPad instead of device. i will fix in the other languages
  3. https://github.com/levinli303/astroweather-localization/blob/4443b147e49865e4f4bbdd4a63c1965617e14d0f/iOS/en/Shared/Localizable.strings#L1970 they both mean network request error underneath
  4. https://github.com/levinli303/astroweather-localization/blob/4443b147e49865e4f4bbdd4a63c1965617e14d0f/iOS/en/Shared/Localizable.strings#L28 let me know if disambiguation is needed
  5. thanks, please do add it in the change you will commit
  6. see below

the iOS localization has multiple files because of history. i've tried to move most of the strings to Shared/Localizable but some will remain in other folders/files and they have to have follow name conventions.

App/InfoPlist.strings for metadata about the app, name, permission clarification

AstroweatherToday folder is for the old pre-iOS 14 style widget that i plan to remove in the future AstroweatherToday/InfoPlist.strings, metadata about the widget AstroweatherToday/MainInterface.strings, the UI was done in old school fashion and comes with this strings file for localization. since i plan to remove it, i will not try to migrate this widget

AstroweatherWidget folder is for iOS14+ style widget AstroweatherWidget/AstroweatherWidget.strings is the file generated for localization for widget configuration. on iOS 17+ i plan to move it to new implementation (means the strings will be duplicated somewhere), but this file will be kept for compatibility indefinitely

Shared/Localizable.strings is for all the strings shared among the app, the old widget and the new widget.

Askaniy commented 1 year ago

1, 2, 6) ok 3) sorry, I'm about astro_title_time_no изображение 4) yes, disambiguation is needed for Russian 7) I don't see text for Precipitation map, as on Android

levinli303 commented 1 year ago

1 is done in https://github.com/levinli303/astroweather-localization/commit/a55b94a72a8fd525504ba8c5058b183d444430ef

  1. this is a placeholder on Android not used on iOS. iOS uses a combination of "Report released at: %@" with "N/A"
  2. added in https://github.com/levinli303/astroweather-localization/commit/b608e34d956d2c83313641f3a8c09a2b39f4fef1
  3. where do you find it i cannot find this string in either iOS or Android
Askaniy commented 1 year ago
  1. I know, the placeholder use on Android made the translation more concise. In fact, the current iOS translation works, just less concisely. 7) I mean line 172 ↓, and it's shown in app too изображение
levinli303 commented 1 year ago

https://github.com/levinli303/astroweather-localization/blob/0cb4d9a5cef86e9c72d8c9b5cdce74346034cf82/iOS/en/Shared/Localizable.strings#L1832 is it this?

Askaniy commented 1 year ago

Not this, above it: изображение Just this is the question. Android has one more weather map than iOS.

levinli303 commented 1 year ago

https://github.com/levinli303/astroweather-localization/blob/0cb4d9a5cef86e9c72d8c9b5cdce74346034cf82/iOS/en/Shared/Localizable.strings#L95

Askaniy commented 1 year ago

I assumed that here one line is responsible for two translations. For the Russian translation, this is not critical, there is no ambiguity. So I leave it up to you

levinli303 commented 1 year ago

i will adopt better keys/comments for iOS when i have time. so let's leave them as they are.