levinsonmm / MI-449-SS17-741-js-collect-and-display-information-kPt9Fl

0 stars 0 forks source link

Project Feedback #1

Open levinsonmm opened 7 years ago

levinsonmm commented 7 years ago

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

egillespie commented 7 years ago

Wow, this looks fantastic. I can see the page updating in real-time and your code is very well organized! :tada:

It looks like you flip-flopped the preview and generated HTML, though. Do mind switching these around so the preview doesn't show any HTML and the code element does?

  preview.textContent = paragraph
  generated.innerHTML = paragraph

After you’ve made this change and pushed it to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! :rocket:

levinsonmm commented 7 years ago

Whoops! I fixed that right up. Thanks for the feedback!

egillespie commented 7 years ago

Perfect, thanks! :shipit: