levito / tt-rss-feedly-theme

Feedly theme for Tiny Tiny RSS
MIT License
643 stars 76 forks source link

Line break rendering #116

Closed apstanley closed 1 year ago

apstanley commented 1 year ago

Hi there. Long time user. I recently updated TT-RSS and the Feedly theme. I've noticed a problem and I don't have the CSS skills to fix myself. I think there's a problem with line break "
" but I'm not 100% sure. If I look at how this theme renders an entry vs the default, there's quite a difference. But this doesn't happen for all entry, however, for example, within http://bt.etree.org/rss/bt_etree_org.rdf you notice how unreadable it is with the Feedly theme. The previous version I used, which was from a couple of years ago, didn't have this problem. Can you see what's wrong or contact me? Thanks.

Screenshot 2023-03-27 151148

Screenshot 2023-03-27 151251

levito commented 1 year ago

Hey @apstanley, really good catch, thanks a lot for submitting this, and for providing the feed so I could check what was happening. Should be fixed now, can you please update and check if it's good now?

apstanley commented 1 year ago

Hi @levito! Thank you for such a quick turnaround. I was not expecting anything this speedy. I would say that it's better for sure, but there's still some spacing issues.

Screenshot 2023-03-27 at 7 18 18 PM

Everything seems double spaced. I was playing around in Firefox and I noticed this part of the stylesheet in web developer tools. Turning it off makes it look like the default:


#content-wrap#content-wrap :where(.post .content, .content-inner) :not(:where(.dijit *)) + :not(:where(.dijit *)) {
  margin-top: 1.5625em;
}

Removing that margin makes it look like:

Screenshot 2023-03-27 at 7 22 49 PM

I can probably hack or override it in TT-RSS, but I'd be curious to hear what you think. Again, thank you VERY much!

levito commented 1 year ago

Thanks for checking again! This should now also be fixed. It was indeed a Firefox-only thing.

If you're interested in what caused it: I recently switched to spacing out the content with the lobotomized owl method. This makes many things easier and helps with consistent spacing, but apparently it has its own issues. Firefox was also adding a margin-top to any br that came after any other tag, so I had to explicitly remove it. Chrome doesn't do this.

The original issue with all the line-breaks being removed was caused by me trying to prevent multiple brs in a row (like Something<br><br><br><br>and more) creating huge gaps with something like br + br { display: none }. But with HTML like Line 1<br>Line 2<br>Line 3, the second br is also matched by br + br, which I didn't consider.

apstanley commented 1 year ago

I just downloaded the update and everything works with no customization. I'll keep my eye on things, but thank you very much.