search

levito / tt-rss-feedly-theme

Feedly theme for Tiny Tiny RSS
MIT License
642 stars 76 forks source link

Score icon functionality #77

Closed fgtham closed 5 years ago

fgtham commented 5 years ago

I really like this theme, thank you for writing it :smile:

I noticed that the score icon behaviour differs in two ways from that of the default theme:

Would it be possible to get the same score icon behaviour as in the default theme?

levito commented 5 years ago

Hi @fgtham,

I would like to keep the theme as clean as possible, that's why the icons are only shown on hover.

I tried the score icon in all 4 display modes and could not reproduce your problem: Clicking the icon always showed the dialog box to modify the score.

Which browser (and version) are you using? Do you use TT-RSS from git? Which version and/or commit do you have?

fgtham commented 5 years ago

I would like to keep the theme as clean as possible, that's why the icons are only shown on hover.

No problem :)

I tried the score icon in all 4 display modes and could not reproduce your problem: Clicking the icon always showed the dialog box to modify the score.

Which browser (and version) are you using?

It does not work with firefox 68 on android and 69 on linux. I just tried with vivaldi 2.8, where it works as expected. I can test other browsers on monday.

Do you use TT-RSS from git?

Yes, I'm using tt-rss f1df2c505. The feedly-theme commit is 8b2c7f9.

levito commented 5 years ago

Good catch, Firefox didn't like the styles. It's fixed now. Thanks for reporting!

fgtham commented 5 years ago

Wow, that was fast. Works fine now. Thanks!

levito commented 1 year ago

Hey @fgtham, I just wanted to let you know that I recently made the score icon stay visible once a score was set. And there are a lot of other improvements on top. Please feel free to give it a try and let me know how you like it!

fgtham commented 1 year ago

Hi @levito thanks for letting me know. I stopped using tt-rss in the meantime and cannot test :frowning_face: