search

levitsky / pyteomics

Pyteomics is a collection of lightweight and handy tools for Python that help to handle various sorts of proteomics data. Pyteomics provides a growing set of modules to facilitate the most common tasks in proteomics data analysis.
http://pyteomics.readthedocs.io
Apache License 2.0
105 stars 34 forks source link

A minimal Universal Spectrum Identifier parser and PROXI client #11

Closed mobiusklein closed 3 years ago

mobiusklein commented 3 years ago

This PR implements a minimal Universal Spectrum Identifier parser and PROXI client to consume USIs and return spectra from Peptide Atlas, MassIVE, PRIDe, and jPOST.

levitsky commented 3 years ago

Thank you! Looks great.

Looking at the test, though, I wonder if there's an easy way to also test the functions without numpy. Also, not sure how much we should care about Python 2 compatibility at this point, but the <= comparison on dictionary keys seems to have a different meaning there. The tests pass as long as the dicts are equal, of course.

mobiusklein commented 3 years ago

You're right, on Py2 dict.keys isn't Set-like. I've fixed that, and removed the dependency on numpy from the test too.

levitsky commented 3 years ago

Ah yes, this is surely the easiest way. I was probably trying to think of something too complex. Thanks again!