search

levitsky / pyteomics

Pyteomics is a collection of lightweight and handy tools for Python that help to handle various sorts of proteomics data. Pyteomics provides a growing set of modules to facilitate the most common tasks in proteomics data analysis.
http://pyteomics.readthedocs.io
Apache License 2.0
105 stars 34 forks source link

Fix UniMod by ID #133

Closed mobiusklein closed 7 months ago

mobiusklein commented 7 months ago

Fixes #132

The psims implementation used one big dispatching resolver for all identifiers, and I forgot to include a by_id alias. __getitem__ should work as intended both with and without psims. If this is a Py2 issue, it may be harder to patch.

levitsky commented 7 months ago

Thank you! I didn't quite get the comment about Py2, should I add a test replicating the code from #132 to check if it runs on Py2 as well? Also, I assume the MGF fix is unrelated? That test was working fine for me locally, was there a platform-specific issue?

mobiusklein commented 7 months ago

The MGF test was failing on GitHub Actions, it was fine locally for me too.