search

levitsky / pyteomics

Pyteomics is a collection of lightweight and handy tools for Python that help to handle various sorts of proteomics data. Pyteomics provides a growing set of modules to facilitate the most common tasks in proteomics data analysis.
http://pyteomics.readthedocs.io
Apache License 2.0
105 stars 34 forks source link

Add pyteomics/version, remove VERSION file #14

Closed levitsky closed 3 years ago

levitsky commented 3 years ago

This PR closes #13. It adds a module, pyteomics/version.py, which defines a __version__ string and a function that parses it into a tuple similar to sys.version_info, with a simple string representation.

levitsky commented 3 years ago

Good point, thanks. I would probably name it version_info though, so that the user doesn't expect a string. Should I rename __version__ to version then?

mobiusklein commented 3 years ago

I think __version__ is expected to be a string still based upon what I've seen. Renaming version to version_info is fine though.

levitsky commented 3 years ago

I'm not sure if __version__ is easy enough to find (as it's not tab-completed) and I see no real reason for it to be private, even though it is common. But we can provide both.