search

levitsky / pyteomics

Pyteomics is a collection of lightweight and handy tools for Python that help to handle various sorts of proteomics data. Pyteomics provides a growing set of modules to facilitate the most common tasks in proteomics data analysis.
http://pyteomics.readthedocs.io
Apache License 2.0
105 stars 34 forks source link

Fix issue #98 for colon-containing mods #99

Closed mobiusklein closed 1 year ago

mobiusklein commented 1 year ago

Closes #98

The behavior is now to treat any colon-containing tag that doesn't have a known prefix as though it were a GenericModification tag. This will lead to strange behavior if we encounter a tag type that we don't support like RESID or XLMOD, with these tags being wrapped in GenericModification instances and then having them explode when someone tries to resolve their properties.

I can add an "unsupported list" to explicitly check those tag types and throw an error pre-emptively, but that might prevent a reasonable use-case of using pyteomics.proforma as a path-through between the user and some other service.

levitsky commented 1 year ago

Thank you @mobiusklein! cc: @caetera