search

levkhomich / akka-tracing

A distributed tracing extension for Akka. Provides integration with Play framework, Spray and Akka HTTP.
Other
308 stars 32 forks source link

server receive sets host explicitly #76

Open codefromthecrypt opened 8 years ago

codefromthecrypt commented 8 years ago

the zipkin core annotations, cs, sr, ss, cr all have the host/endpoint field to the "local" process, just like if you were making a log statement. So, if you are a client, the "cs" is you, for example.

I noticed that the serviceName is parameterized here: https://github.com/levkhomich/akka-tracing/blob/fb4a6a18898b6e746764ba9ceaba7cd033cf5a55/core/src/main/scala/com/github/levkhomich/akka/tracing/actor/SpanHolder.scala#L147

Not sure this is being misused, just mentioning if the goal is to allocate who the peer is, there's a binary annotation for that, for example "sa" if you are a client and want to log who the server is.

Here's the description in the thrifts: https://github.com/openzipkin/zipkin/blob/master/zipkin-thrift/src/main/thrift/com/twitter/zipkin/zipkinCore.thrift#L201

Here's how it works in brave: https://github.com/openzipkin/brave/blob/fd7f09cb61861ce70a60fd0baec0b011a964c1ee/brave-core/src/main/java/com/github/kristofa/brave/ClientRequestAdapter.java#L50 https://github.com/openzipkin/brave/blob/master/brave-core/src/main/java/com/twitter/zipkin/gen/BinaryAnnotation.java#L39

Hope this helps

levkhomich commented 8 years ago

Interesting, zipkinCore.thrift was a lot shorter back in time. I will check these annotations and improve interop where needed.

Thank you!

codefromthecrypt commented 8 years ago

It sure was! Took us a while to figure out what each thing was for!