mdi-react-native - Githubissues

d4rky-pl commented 4 years ago

Hey! I love your library!

It would be amazing if other than mdi-react and mdi-preact there was a third option, mdi-react-native. The differences would be tiny:

do not apply default className
replace svg and path with import Svg, { Path } from 'react-native-svg'
I'm not 100% sure right now but I think fill needs to be applied on Path instead of Svg

I'd love to send a PR but I'm not a TypeScript person so I gave up after trying to fix the typings (sorry!)

Would you be interested in adding this and releasing it as your own library or would you rather not maintain any extra baggage and I should just fork? :)

levrik commented 4 years ago

Hey there. Just leave the TypeScript typings out and open a PR. I'll add them to your PR.

levrik commented 4 years ago

Any updates on this from your side?

d4rky-pl commented 4 years ago

Sorry! We ultimately went with a different approach and I totally forgot about this 🤦‍♂ I'll take a look later today and will send a PR 👍

d4rky-pl commented 4 years ago

Just to let you know, I remember about this issue but couldn't find time because of traveling 😅 Please keep it open!

jjarrett21 commented 4 years ago

Any updates on this?

d4rky-pl commented 4 years ago

To be honest due to the global pandemic and everything related to it, I completely forgot about this issue and the code I already had prepared.

I sent a PR #79, it still requires TS fixes though.

levrik / mdi-react

mdi-react-native #71