levylabpitt / AFM-Lithography

BSD 3-Clause "New" or "Revised" License
7 stars 0 forks source link

Building Issues #57

Closed Monkeymerlot closed 3 years ago

Monkeymerlot commented 3 years ago

I have been trying to compile and package the develop branch of this repository and keep running into building issues. I managed to get the build to work once, but then I tried to use the installer and it said that the files were corrupted. In attempting to build again I ran into the following error: image

Monkeymerlot commented 3 years ago

Tried to build again today. Got the same error as above...

ciozi137 commented 3 years ago

@Monkeymerlot what branch and what version of labview?

ciozi137 commented 3 years ago

Also can you build the application or installer directly from the build spec in the lv project?

Monkeymerlot commented 3 years ago

Develop branch, and LabVIEW 2020, VIPM 2020.0.0 (Pro Edition)

Monkeymerlot commented 3 years ago

@ciozi137 Ill try that right now.

ciozi137 commented 3 years ago

Somewhat unrelated but you should update to vipm 2020.3. and lv 20 has a service pack

Pertinent question: do we need to make a package for afm litho? Or would just building an exe be good enough? Or, can we separate the two, meaning the exe application is distinct from any packages we might need.

Monkeymerlot commented 3 years ago

I built the application directly from LabVIEW. It seems to work fine minus the fact that I forgot to take it out of debug mode... image

and I think that an installer/executable would be fine.

Monkeymerlot commented 3 years ago

OK, it's been a while since I have even looked at NIPM. Currently updating everything.

And basically I want to merge develop into main, and make a new release. Then hopefully, with all of the corrections/bug fixes it will work on Cypher and I can get back to improving the program architecture. After this I want to implement the new parser, and then start on the tooling, as these were the parts that caused the most issues in the past. But I don't want to implement these yet because I am expecting there to be some additional bugs that will inevitably crop up despite my best efforts/unit tests.

ciozi137 commented 3 years ago

I can look at the build tomorrow. I have a slightly different solution for applications that are strictly exe/installer

ciozi137 commented 3 years ago

@Monkeymerlot I added a file called "Build AFM Litho Installer.vi". It's basically a simplified version of the "Auto Build Script". Make you sure you have the latest "Build Support" and "MakerHub Toolbox" packages

Monkeymerlot commented 3 years ago

I needed to change src to lvsrc. Running it now.

Monkeymerlot commented 3 years ago

@ciozi137 Does this output an installer? I only can find the exe...

ciozi137 commented 3 years ago

There should be an exe in the "builds/latest" folder. Which will be a self-extracting installer

Monkeymerlot commented 3 years ago

This is what is in builds/latest for me: image

In the builds/Application folder I have the new exe though: image

ciozi137 commented 3 years ago

How about the builds/installer?

Monkeymerlot commented 3 years ago

It seems like all the other files updated but the installer itself. Let me check really quick if it works. image

Monkeymerlot commented 3 years ago

Maybe I need to put in the correct number when I build it... image

I'll try that and get back to you.

ciozi137 commented 3 years ago

Yes windows is smart about that actually. I’m not sure why the exe installer wasn’t made. Did you see a blank command window pop up?

On Wed, Jan 27, 2021 at 7:22 PM Joseph Albro notifications@github.com wrote:

Maybe I need to put in the correct number when I build it... [image: image] https://user-images.githubusercontent.com/37567672/106071794-f84c1100-60d4-11eb-9c36-524191c25678.png

I'll try that and get back to you.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/levylabpitt/AFM-Lithography/issues/57#issuecomment-768666710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLMUZHZOAJKJUHURVN5KJTS4CU5LANCNFSM4VWLQMXQ .

Monkeymerlot commented 3 years ago

That worked! And yes I did both times. It still says modified in February of last year but it installed the right thing so..

ciozi137 commented 3 years ago

What says February?

Monkeymerlot commented 3 years ago

The last modified date of the installer (setup.exe)

ciozi137 commented 3 years ago

Doesn't sound right. The installer should be called something like "afm lithography-x.x.x.x.exe"

Monkeymerlot commented 3 years ago

Yeah mine just says setup.exe. Have you tried building it?

Monkeymerlot commented 3 years ago

When I built it with VIPM earlier this month it produced an installer called General AFM Lithography-8.6.0.8-install.exe

Monkeymerlot commented 3 years ago

Im going to try building with the version as 8.6.0.9. I did not realize that the old attempts left behind an installer that was different than the current package number I had used (8.6.0.7)

Monkeymerlot commented 3 years ago

Didn't change anything....

ciozi137 commented 3 years ago

No I didn’t try it yet. I’ll try later tonight or tomorrow

On Wed, Jan 27, 2021 at 9:12 PM Joseph Albro notifications@github.com wrote:

Didn't change anything....

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/levylabpitt/AFM-Lithography/issues/57#issuecomment-768746048, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLMUZEG4VCXOAWW7VGNBZLS4DBYFANCNFSM4VWLQMXQ .

ciozi137 commented 3 years ago

Had to install vision. Now getting FTD2 errors from relay box...

Monkeymerlot commented 3 years ago

If you post a quick video on how you solved the bootstrapping issues, I can do a write up for the developer wiki... Just a thought.

ciozi137 commented 3 years ago

K I'll have an update in a minute. Building now...

Monkeymerlot commented 3 years ago

Ok perfect.

ciozi137 commented 3 years ago

Simple fix: I forgot to wire the source path terminal: image

Output: image

Regarding the "date modified" of setup.exe in builds/installer, I think that is a generic binary like "labview.exe" that ingests some other data to install the stuff.

I could not fix FTD2XX.dll on my machine. That is a different beast:

Monkeymerlot commented 3 years ago

Ok so I can build it, but now it is saying that the file is corrupt... (I have tried to build twice just to make sure it wasn't a fluke) image

ciozi137 commented 3 years ago

image

ciozi137 commented 3 years ago

try deleting your entire builds folder

Monkeymerlot commented 3 years ago

Didn't fix the issue. It asks if I want to install it and then the error pops up. It seems like it might be something with the zipping?

And I think I might have found the problem: image

ciozi137 commented 3 years ago

That "not installed correctly" window pops up if you cancel the installation, I think. It worked ok for me on my VM. I don't think you need to have 7z installed. I'm not sure what to suggest. So you can build the exe and installer fine individually from the project?

Monkeymerlot commented 3 years ago

I guess pressing OK on the "File is corrupt" dialogue probably cancelled the installation...

Monkeymerlot commented 3 years ago

And I am reinstalling the file libraries used in the build support package. Then I'll check the project.

Monkeymerlot commented 3 years ago

That didn't work. I am trying to build it with the project now...

Monkeymerlot commented 3 years ago

Ok so the only thing that doesnt seem to work is the zipping and extraction. It builds the installer just fine from the project (even the script seems to work fine). Maybe I can just manually create a self extracting zip using 7zip?

ciozi137 commented 3 years ago

does this command work: 7z.exe a Volume.7z "..\Installer\Volume\*"

Monkeymerlot commented 3 years ago

@ciozi137 I found the issue. It is looking for 7 zip in "C:\Program Files\7-Zip", but my location is "C:\Program Files (x86)\7-Zip"

ciozi137 commented 3 years ago

The BAT file augments %PATH% with C:\Program Files\7-Zip. Sounds like either way 7z.exe wasn't in your path. Command line on Windows isn't so good...

Monkeymerlot commented 3 years ago

Yeah I had to change the BAT file. I made a small change in the build support to accommodate this and am testing if it will work right now.

Monkeymerlot commented 3 years ago

Command line on Windows isn't so good...

Understatement of the past 3 decades...

Monkeymerlot commented 3 years ago

It worked!

Changes made to write 7z.bat.vi: image

ciozi137 commented 3 years ago

Great! If you want to take a stab at updating the "build support" package go for it. But you need to use LV2016

Monkeymerlot commented 3 years ago

OK I pushed the changes to build support.