levylabpitt / Instrument-Framework

An object-oriented framework for LabVIEW based on JKI SMOs.
BSD 3-Clause "New" or "Revised" License
4 stars 7 forks source link

Improve Instrument Configuration #68

Closed ciozi137 closed 1 year ago

ciozi137 commented 2 years ago

Instruments (MNK, PPMS, etc) should be configured via file configuration rather than constants inside VIs.

What to configure:

ciozi137 commented 2 years ago

Configuration window should be block diagram template

ciozi137 commented 2 years ago

Instrument (implementation) Dependencies is issue for Transport package

ciozi137 commented 2 years ago

Generalize Configuration subsystem #5

ciozi137 commented 2 years ago

Improvement A: Exert better control over section names

Issue: If clusters have the same name, e.g. "configuration", I think there can be unexpected behavior: image

Solution: Add section parameter to Configuration.lvclass private data. Called automatically by Instrument.lvclass: Read Configuration Class.vi: image

API is exposed such that other users of Configuration class can set the section themselves: image

Makes an easier to read config file: image

ciozi137 commented 2 years ago

Added pgsql paths and get all cluster information to class private data. Try to read from class wire first (which was initialized from the config file): image

Override method looks like this: image