levylabpitt / Transport

VIs for scripting and performing transport measurments.
Other
0 stars 0 forks source link

Sweep control does not save json file #63

Closed 1ranjani1 closed 1 year ago

1ranjani1 commented 1 year ago

Does not save comments json file, but the state runs without error. Maybe it is related to Issue 55

1ranjani1 commented 1 year ago

image

ciozi137 commented 1 year ago

@1ranjani1: Up till now there would be a json file saved each time:

  1. Control experiment was run
  2. A Transport VI was run (Lockin_time)
  3. Sweep program was run (Sweep_control).

Moving forward I would prefer to save the json-formatted metadata inside the tdms file. How does this sound?

ciozi137 commented 1 year ago

@1ranjani1 ie, https://github.com/levylabpitt/Transport/issues/40, this issue was "fixed" already. Is there a problem?

1ranjani1 commented 1 year ago

All my other experiments till Aug 2022 have this json file in the folder, from whre I read comments. image

After Oct 2022, none of the experiment files have this json file. the comments tab is empty while opening data from the data analysis programs

ciozi137 commented 1 year ago

image

The json-formatted notes are saved in channels named \, \, and \

  1. Is there an issue with the channels having "\<" or ">" in the name? Perhaps they should be named something else (In particular, the \ channel will be problematic because it is sometimes named \). Should they be combined into one "json-notes" channel?
  2. I think that the "notes" channel should not be empty, but we can discuss since the information is contained inside the json channels
1ranjani1 commented 1 year ago

The tdms file have these comments image image What about the experiment description that I type out in the sweep control? Perhaps we should discuss in person tomorrow

ciozi137 commented 1 year ago

@1ranjani1 our messages crossed. But yes we can discuss in person