search

lewa-j / Unity-Source-Tools

Plugin to import resources from the Source engine in Unity3D.
GNU General Public License v2.0
109 stars 22 forks source link

Updating project to 2018.2.1f1 #2

Closed StamatisP closed 6 years ago

StamatisP commented 6 years ago

This has fixed mostly everything EXCEPT the lightmaps. Do not enable lightmaps, they break textures.

I have also added some debug logs and a new player controller. Anything else I added, I kinda forgot. Hopefully this is up to your standards!

lewa-j commented 6 years ago

Thank you for updating the code. But since there are a lot of style revisions in the same commit, it's hard to keep track of what makes sense. But in fact, I do not care, so it's normal. Can I merge or do you want to finish something else?

StamatisP commented 6 years ago

I believe that's everything I wanted to include in. Apologies for the large number of changes, VSCode automatically formats it to make it look a bit nicer.

I added PlayerControllerv2 to mimic the Source-style movement at least a little bit.

You can see the changes I've made in here. Remember to turn on "hide whitespace"

As for the above changes you commented, I have no idea. It was either Unity changing that or VSCode, as I have never touched it. Turns out Unity got rid of the function, and it is now obsolete, and only works in the editor. https://docs.unity3d.com/ScriptReference/MeshUtility.Optimize.html

I didn't mean to include the readme, but it should be fine to keep, right?

lewa-j commented 6 years ago

You can see the changes I've made in here. Remember to turn on "hide whitespace"

Oh thanks. I did not know about it.

Turns out Unity got rid of the function

Well then those lines where it was used can be deleted, it's not so important.

I didn't mean to include the readme, but it should be fine to keep, right?

Of course. It's good.