search

lewagon / data-setup

Setup instructions for Le Wagon's students on their first day of Data Science Bootcamp
https://www.lewagon.com/data
1.8k stars 509 forks source link

Inconsistency between .zshrc file and .../lewagon/data-setup/blob/master/WINDOWS.md #206

Closed leetoo closed 2 months ago

leetoo commented 2 years ago

Small thing but anyway. I'm encounter that number of plugis in instruction .../lewagon/data-setup/blob/master/WINDOWS.md different from in the dotfile .../dotfiles/blob/master/zshrc

plugins=(git gitfast last-working-dir common-aliases zsh-syntax-highlighting history-substring-search pyenv)

image

To avoid probable conflict between 'git' and 'gitfast' plugins (it could happen in the future releases of plugins), I propose choosing one plugin, either 'git' or 'gitfast'. Alternatively, ignore it and add the 'git' plugin to the instruction to avoid confusion from future students.

julesvanrie commented 2 months ago

Screenshot has been removed. Inconsistency is also gone (pyenv is no longer in the plugins - we use a different method now).

As to git and gitfast, from what I can find, they serve a different purpose (shortcuts vs completion) and so far we didn't really encounter any problems with it.