lewagon / nbresult

Testing Library for Jupyter Notebooks
https://pypi.org/project/nbresult/
MIT License
8 stars 2 forks source link

enable selecting test folder when using nbresult in notebooks #6

Closed brunolajoie closed 2 years ago

brunolajoie commented 2 years ago

The following PR updates nbresult (without breaking it)

Before

Previously, we could only use nbresult in notebooks at the root image

After

Now, we can specify in which subdir folder to store the pickle and where to read the pickle and the test_xxx.py image

Demo repo as per screenshot here

Why need this ?

This can be useful for taxifare-model project, where we regroup all tests of the week in the ./tests with 1 subdir per challenge, some test launched from notebooks in ./notebooks, while some other are launched from Makefile and targetting python code located in ./taxifare_model/ml_logic for instance

brunolajoie commented 2 years ago
krokrob commented 2 years ago

What does the make command returns (before diving into the code) ? cc @brunolajoie

brunolajoie commented 2 years ago

Actually, Make works as well!

brunolajoie commented 2 years ago

kev feel free to merge

brunolajoie commented 2 years ago

@gmanchon let's merge?

krokrob commented 2 years ago

AWESOME @brunolajoie