search

lewagon / setup

Setup instructions for Le Wagon's students on their first day of Web Development Bootcamp
https://www.lewagon.com
18.65k stars 1.6k forks source link

Le Wagon Setup now in Portuguese version too #442

Closed carlosferrerdev closed 1 year ago

carlosferrerdev commented 1 year ago

Good afternoon, Le Wagon.

I created a Portuguese version of Le Wagon Setup to help the entire Le Wagon global community who speak Portuguese as their native language.

I'm making this pull request to check if everything is in order to merge and help the community. :)

olivergiles commented 1 year ago

Hi @carlosferrerdev, thanks for this I don't see any problem adding an extra language but it needs to split into partials! If you see in this folder https://github.com/lewagon/setup/tree/master/_partials there is a .md per section and then folders for the alternative languages. So a pt folder needs to created and populated and then pt it needs to be added to this line https://github.com/lewagon/setup/blob/master/build.rb#L97C1-L98C40!

carlosferrerdev commented 1 year ago

Hi @carlosferrerdev, thanks for this I don't see any problem adding an extra language but it needs to split into partials! If you see in this folder https://github.com/lewagon/setup/tree/master/_partials there is a .md per section and then folders for the alternative languages. So a pt folder needs to created and populated and then pt it needs to be added to this line https://github.com/lewagon/setup/blob/master/build.rb#L97C1-L98C40!

Hi, @ogiles1999. Thanks for this comment. I will do the mencioned changes.

carlosferrerdev commented 1 year ago

Hey @ogiles1999, Can you check the changes I've made? Thanks :)

olivergiles commented 1 year ago

If you want to check the output looks all good it looks like it has generated correctly https://github.com/lewagon/setup/blob/master/README.pt.md