lewagon / setup

Setup instructions for Le Wagon's students on their first day of Web Development Bootcamp
https://www.lewagon.com
18.29k stars 1.6k forks source link

WINDOWS: fix warning "bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf-8) #459

Closed v-natalia closed 6 months ago

v-natalia commented 6 months ago

Hi, Many students get this warning after running the commands of the section locale:

bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf-8)

I've seen this in students with laptops configured to use other languages different than english, and so they get this warning even after generating the locale. I propose to add the following paragraph to the section locale


If after, you receive a warning ("bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf-8)) in your terminal, please do the following:

<details>
  <summary>Generate locale</summary>
Please, run this lines in your terminal.
```bash
sudo update-locale LANG=en_US.UTF8
sudo apt-get install language-pack-en language-pack-en-base manpages
exec zsh

v-natalia commented 6 months ago

cc @xeonnux

xeonnux commented 6 months ago

I confirm this is very common during the setup days. I would also recommend moving the locale section in the setup to right after the dotfiles section since this is usually around there that the issue pops up and would be more effective.

Also the student should definitely run

exec zsh

right after running the above mentioned commands from @v-natalia to see it effective.

(c/c @ajdubovoy )

v-natalia commented 6 months ago

I just added this line, thanks @xeonnux

ajdubovoy commented 6 months ago

Hi! I'm adding this right now. @xeonnux I'm not sure what you mean about the order though? The locale section is before the dotfiles already

xeonnux commented 6 months ago

@ajdubovoy what I mean is locale should be removed from the ubuntu section and moved to this section here https://github.com/lewagon/setup/blob/master/windows.md#git-installer

ajdubovoy commented 6 months ago

Oh, understood. Is there any advantage to moving it down if we're already making sure it works properly further up?