search

lewagon / setup

Setup instructions for Le Wagon's students on their first day of Web Development Bootcamp
https://www.lewagon.com
18.66k stars 1.6k forks source link

Update yarn installation instructions #469

Closed ajdubovoy closed 1 month ago

ajdubovoy commented 5 months ago

resolve https://github.com/lewagon/setup/issues/464

ajdubovoy commented 5 months ago

@Eschults implemented the recommendation in https://github.com/lewagon/setup/issues/464.

But, I don't really have a good way of testing it. I did find corepack is installed on my system already, so this bodes well.

@ElvisDot do you maybe have a burner system you could test this on hahah? No worries if no!

I could also always try setting up a DigitalOcean droplet for a day and see if I can run our setup via SSH on Ubuntu, I guess.......

ajdubovoy commented 5 months ago

No worries! But do we feel comfortable merging this without having at least tested it on Windows once?

Eschults commented 5 months ago

Let's ask in #teachers if someone is on Windows and would be so kind to run the two commands for us 😇

ajdubovoy commented 5 months ago

Ok will do!

ajdubovoy commented 5 months ago

https://lewagon-alumni.slack.com/archives/G02NFDT0J/p1716393474945849

ajdubovoy commented 5 months ago

Hmmm so apparently it doesn't work with our node version on Ubuntu.

https://lewagon-alumni.slack.com/archives/G02NFDT0J/p1716555678386209?thread_ts=1716393474.945849&channel=G02NFDT0J&message_ts=1716555678.386209

I guess should we table merging this until we upgrade mode?

ElvisDot commented 5 months ago

Works on my machine. Did not test a lot just corepack enable and using yarn to install some package.

ajdubovoy commented 5 months ago

It also seems like the issue on Natalia's computer was actually some kind of network error we haven't been able to solve yet. I do wonder if the same thing might happen to students, but it's also not necessarily a reason not to merge this

ajdubovoy commented 5 months ago

I also think we don't use yarn at any point in the bootcamp anymore, so it wouldn't be a breaking problem if it didn't install on somebody's laptop

Eschults commented 1 month ago

👍