lewagon / setup

Setup instructions for Le Wagon's students on their first day of Web Development Bootcamp
https://www.lewagon.com
18.29k stars 1.6k forks source link

[Important PR~not to merge without deployment plan] Upgrade to Node 20 #474

Open ajdubovoy opened 1 week ago

ajdubovoy commented 1 week ago

resolve https://github.com/lewagon/setup/issues/441

I did a pretty exhaustive look through our repos, and as far as I can tell, I actually don't think upgrading node will change so much stuff!

I changed the version here in setup. Then, in fullstack-challenges, I added an .nvmrc file for those with it set up to change their version with nvm automatically. And I did the same in fullstack-solutions and then went into every single challenge in the JS units and ran rake to make sure they still raked green, ran serve to check the result myself, and ran eslint --fix * to improve the style.

But, given that the students really never use node during the challenges, I actually don't think this should affect much. And, we don't use node in Rails anymore, so I don't think it should affect any of the rails lectures or any of our Rails-related repos, agreed?

I feel like there should be more to do or something...but I think this is actually everything?

related:

Eschults commented 1 week ago

👋 @ajdubovoy, indeed it should be pretty safe to upgrade w/o disrupting challenges / solutions. That said, have you checked

ajdubovoy commented 1 week ago

Taking a look now:

ajdubovoy commented 1 week ago

opened prs for this

ajdubovoy commented 1 week ago

All of those seemed super tiny to me and unlikely to cause issues!

ajdubovoy commented 1 week ago

FYI also, unrelated but similar. I've started going through repos one by one and opening prs to move to the latest version of Ruby. I'll make a big pr in setup and link to alllllll the prs in the other repos once I'm done, so don't worry about checking those prs individually at the moment