[Important PR~not to merge without deployment plan] Upgrade to Node 20

[ajdubovoy]

resolve https://github.com/lewagon/setup/issues/441

I did a pretty exhaustive look through our repos, and as far as I can tell, I actually don't think upgrading node will change so much stuff!

I changed the version here in setup. Then, in fullstack-challenges, I added an .nvmrc file for those with it set up to change their version with nvm automatically. And I did the same in fullstack-solutions and then went into every single challenge in the JS units and ran rake to make sure they still raked green, ran serve to check the result myself, and ran eslint --fix * to improve the style.

But, given that the students really never use node during the challenges, I actually don't think this should affect much. And, we don't use node in Rails anymore, so I don't think it should affect any of the rails lectures or any of our Rails-related repos, agreed?

I feel like there should be more to do or something...but I think this is actually everything?

related:

• https://github.com/lewagon/fullstack-challenges/pull/2714
• https://github.com/lewagon/fullstack-solutions/pull/320

[Eschults]

👋 @ajdubovoy, indeed it should be pretty safe to upgrade w/o disrupting challenges / solutions. That said, have you checked

• lectures & challenges boilerplates (you can find them all here)
• French certification challenge templates

❓

[ajdubovoy]

Taking a look now:

• https://github.com/lewagon/ajax-in-rails seems to still be on webpacker, but it's also not used anywhere in the curriculum now
• https://github.com/lewagon/rails-search also is still on webpacker. I think we should just merge the importmap branch?
• https://github.com/lewagon/rails-testing similar, but I think it's only referenced from a single tutorial in the Knowledge tab
• https://github.com/lewagon/the-fork-api similar. I'm not even sure this is referenced anywhere? I think it's actually just that the students make requests to it in a JS challenge, if memory serves
• https://github.com/lewagon/uikit seems to still be on webpacker too. But I don't think students ever look at this repo....it's just the one that's used to make the Front End Components page on Kitt, no?

[ajdubovoy]

• https://github.com/lewagon-assess/rails-book-rooms-challenge seems to be on importmap (yay) but for some reason has an empty node_modules/ directory committed. Not really important but maybe we should delete that?
• https://github.com/lewagon-assess/rails-share-posts-challenge same—node_modules/ is there but not used
• https://github.com/lewagon-assess/rails-rent-cars-challenge same

opened prs for this

[ajdubovoy]

All of those seemed super tiny to me and unlikely to cause issues!

[ajdubovoy]

FYI also, unrelated but similar. I've started going through repos one by one and opening prs to move to the latest version of Ruby. I'll make a big pr in setup and link to alllllll the prs in the other repos once I'm done, so don't worry about checking those prs individually at the moment

[ajdubovoy]

@Eschults ok if I merge this one as well?

[Eschults]

🚀