lewagon / wait-on-check-action

This action can be used to halt any workflow until required checks for a given ref (e.g., in a sibling workflow) pass successfully.
MIT License
343 stars 62 forks source link

Deprecation warnings from dependencies? #76

Closed ditman closed 1 year ago

ditman commented 1 year ago

Hello team!

We're using lewagon/wait-on-check-action, and we've started seeing deprecation warnings coming from the dependencies of the action in our logs:

ruby/setup-ruby@1.81.0

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using
Environment Files. For more information see:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

actions/cache@v2

Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using
Environment Files. For more information see:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Also a warning about "Node.js 12 actions being deprecated" for both of the above:

Node.js 12 actions are deprecated. For more information see:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16: ruby/setup-ruby@v1.81.0, actions/cache@v2

Is this something that we can fix on our end, or is this something that the wait-on-check-action needs to fix?

Thanks!

quinnturner commented 1 year ago

This will be solved with my PRs here: #74 #75.

ditman commented 1 year ago

Thanks for the fixes @quinnturner!