search

lewang / flx

Fuzzy matching for Emacs ... a la Sublime Text.
GNU General Public License v3.0
519 stars 37 forks source link

Enable lexical binding #116

Closed LemonBreezes closed 7 months ago

LemonBreezes commented 1 year ago

Hi. I have inspected your codebase and found no code which presents a problem with enabling lexical-binding. One day Emacs will enable lexical binding by default so it's better merge this earlier to reduce the risk of a mass config breakage event. This PR will give a free performance boost for all users.

oscarfv commented 1 year ago

Thank you for reviewing the code.

Have you measured the performance boost you mention?

LemonBreezes commented 1 year ago

Thank you for reviewing the code.

Have you measured the performance boost you mention?

No.

LemonBreezes commented 7 months ago

Thank you for reviewing the code.

Have you measured the performance boost you mention?

Hey, now Emacs30 emits a byte compiler warning for lexical binding not being explicitly set.

PythonNut commented 7 months ago

I ran the tests and everything passed, so I'm merging it.