flx: introduce flx-dir-face for directories

[artagnon]

So it's easy to distinguish between files and directories: it complements flx-highlight-face, and does not conflict with it.

Signed-off-by: Ramkumar Ramachandra artagnon@gmail.com

[bbatsov]

ido normally doesn't highlight directories and I'm not sure what difference would it make if flx-ido used a different face for them. Maybe you can submit here a screenshot illustrating the advantages of the suggested face?

[artagnon]

Um, it's just a port of the ido-subdir face.

[artagnon]

... and the screenshot:

[lewang]

@artagnon If ido-subdir already exists, can you amend your patch to use it (i.e. don't define a new face) conditionally based on ido-use-faces?

[bbatsov]

I think that ideally the flx face should always be appended to the Ido faces rendering the need to disable Ido's faces obsolete.

On Sunday, July 28, 2013, Le Wang wrote:

@artagnon https://github.com/artagnon If ido-subdir already exists, can you amend your patch to use it (i.e. don't define a new face) conditionally based on ido-use-faces?

— Reply to this email directly or view it on GitHubhttps://github.com/lewang/flx/pull/36#issuecomment-21677611 .

[lewang]

@bbatsov You mean like #22 ? I haven't had time to look into that yet. I'm not that familiar with Emacs faces.

[bbatsov]

Yep, exactly. Appending the face will automatically solve all problems related to the disabled Ido faces.

On Sunday, July 28, 2013, Le Wang wrote:

@bbatsov https://github.com/bbatsov You mean like #22https://github.com/lewang/flx/issues/22? I haven't had time to look into that yet. I'm not that familiar with Emacs faces.

— Reply to this email directly or view it on GitHubhttps://github.com/lewang/flx/pull/36#issuecomment-21677665 .

[lewang]

@artagnon I'm trying your branch ... flx-highlight-face supposed still work within directory items? It doesn't for me.

[lewang]

I see from the screenshot it does for you ... double checking.

[artagnon]

Double-check that it's not picking up a precompiled elc?

[lewang]

I just started from emacs -Q and manually eval'ed the files and still no good. I'm using 24.3.1 . I know this has changed in master recently, though.

[lewang]

ah, you've disabled ido faces. as per my instructions. I see.

[artagnon]

Yes, you have no choice but to disable ido faces, otherwise they'll override whatever faces you set in flx. I already wrote about it detail: https://github.com/lewang/flx/issues/22#issuecomment-21681521

[bbatsov]

Btw, one more thing that worries me about this patch - it's basically ido specific code in the ido independent portion of flx. Ido specific code should be restricted to flx-ido.el IMO, which is another argument in favor of overriding ido-complete as suggested by @artagnon.

[lewang]

@artagnon @bbatsov I've followed #22 and should have something along those lines soon.

[lewang]

I intended to advice ido-completions, with flet binding but put-text-property to something else, but since put-text-property is defined in C I ran into all kinds of trouble.