search

lewang / flx

Fuzzy matching for Emacs ... a la Sublime Text.
GNU General Public License v3.0
518 stars 37 forks source link

Fix incorrect word count for camelCase. #74

Open Fuco1 opened 8 years ago

Fuco1 commented 8 years ago

The variable word-count is only determined on flx-word-p which doesn't break on camelCase changes. OTOH, words-length properly reflects the number of words (based on flx-boundary-p.

Further, we might probably want to remove the word-count variable alltogether, it doesn't serve any purpose as it just mirrors words-length but in an inconsistent way.

lewang commented 8 years ago

This change breaks legit tests (yay testing!). I will think about refactoring the code around this. It's pretty hard for me to parse the code 1+ years on though.

Fuco1 commented 8 years ago

Well it probably breaks the examples which tested the wrong case originally. It seems only those where the property is violated fail.

lewang commented 8 years ago

This is the valid test I'm talking about - https://github.com/lewang/flx/blob/master/tests/flx-test.el#L296 .

lewang commented 8 years ago

I haven't forgotten about this. There are some other optimizations coming in and I'll revisit this after that PR is merged.

Fuco1 commented 8 years ago

Thanks for the update.