search

lewang / ws-butler

Unobtrusively trim extraneous white-space *ONLY* in lines edited.
242 stars 26 forks source link

Don't make hooks buffer-local #20

Closed Andersbakken closed 7 years ago

Andersbakken commented 8 years ago

I like ws-butler but since it makes its hooks buffer-local it stomps on all my other hooks.

E.g.

after-save-hook is a variable defined in ‘files.el’. Its value is (t ws-butler-after-save) Original value was nil Local in buffer *magit: ws-butler; global value is (update-gtags executable-make-buffer-file-executable-if-script-p backup-file magit-refresh-status-buffer rmail-after-save-hook rtags-after-save-hook)

I don't see why the hook should be buffer-local.

lewang commented 8 years ago

My assumption is not everyone will want this behaviour everywhere.

According to the documentation https://www.gnu.org/software/emacs/manual/html_node/emacs/Hooks.html If t is in the local hook, the global version will be run as well. I will accept a PR for that change.

On Mon, Mar 21, 2016 at 11:42 AM, Anders Bakken notifications@github.com wrote:

I like ws-butler but since it makes its hooks buffer-local it stomps on all my other hooks.

E.g.

after-save-hook is a variable defined in ‘files.el’. Its value is (t ws-butler-after-save) Original value was nil Local in buffer *magit: ws-butler; global value is (update-gtags executable-make-buffer-file-executable-if-script-p backup-file magit-refresh-status-buffer rmail-after-save-hook rtags-after-save-hook)

I don't see why the hook should be buffer-local.

You can view, comment on, or merge this pull request online at:

https://github.com/lewang/ws-butler/pull/20 Commit Summary

  • Don't make hooks buffer-local

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/lewang/ws-butler/pull/20

Le

lewang commented 7 years ago

@Andersbakken I see that when adding hooks as "buffer-local" t is always added, which means your global hooks would also be run. Is this still a problem for you?

Andersbakken commented 7 years ago

Hi Le

I am not actually having an issue with it anymore. I'm not sure why but very likely it was a pebkac on my end. I think you can safely disregard this bug report.

Anders

On Wed, Jan 11, 2017 at 12:47 PM, Le Wang notifications@github.com wrote:

@Andersbakken https://github.com/Andersbakken I see that when adding hooks as "buffer-local" t is always added, which means your global hooks would also be run. Is this still a problem for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lewang/ws-butler/pull/20#issuecomment-271989462, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEdSvkhR1DIG7POnDhlJzZ4boZeOYieks5rRT_4gaJpZM4H1RjU .

lewang commented 7 years ago

👍