lewapek / sds-dust-sensors-arduino-library

Library for Nova Fitness SDS dust sensors family (SDS011, SDS021)
MIT License
65 stars 19 forks source link

Compilation fails on Arduino Nano 33 BLE (Sense) #27

Open mafavaron opened 3 years ago

mafavaron commented 3 years ago

Hello, and first of all thanks for your great and useful library!

By compiling code containing reference to "SdsDustSensor.h" on Arduino IDE 1.8.42.0 using card "Arduino Nano 33 BLE" I get the following error:

............\Documents\Arduino\libraries\Nova_Fitness_Sds_dust_sensors_library\src/SdsDustSensorResults.h:6:10: fatal error: SoftwareSerial.h: No such file or directory

include

I've checked the code and in "Serials.h" found the lines

ifndef ARDUINO_SAMD_VARIANT_COMPLIANCE // there is no SoftwareSerial available (needed) on SAMD boards.

include

endif

include

My suspect is, the Nano 33 BLE is a different category than ARDUINO_SAMD, and as with ARDUINO_SAMD the "SoftwareSerial.h" library is missing.

lewapek commented 3 years ago

Thanks! You're right - #ifndef needs to be modified to exclude SoftwareSerial for that board too. @mafavaron If you managed to solve it, please open PR with the change :)

Ernstbert commented 3 years ago

Hello, and first of all thanks for your great and useful library!

By compiling code containing reference to "SdsDustSensor.h" on Arduino IDE 1.8.42.0 using card "Arduino Nano 33 BLE" I get the following error:

............\Documents\Arduino\libraries\Nova_Fitness_Sds_dust_sensors_library\src/SdsDustSensorResults.h:6:10: fatal error: SoftwareSerial.h: No such file or directory

include

I've checked the code and in "Serials.h" found the lines

ifndef ARDUINO_SAMD_VARIANT_COMPLIANCE // there is no SoftwareSerial available (needed) on SAMD boards. #include #endif #include

My suspect is, the Nano 33 BLE is a different category than ARDUINO_SAMD, and as with ARDUINO_SAMD the "SoftwareSerial.h" library is missing.

Hello! Could you find a way to make this work?! I ask so bluntly because it has been some time and you might have a solution, but didnt mention it :P I am also using the Arduino Nano 33 BLE and I would like to use this library for the SDS011 dust sensor.

lewapek commented 3 years ago

Hi, I'm not using that board and I didn't test any solution. In case you it working for that board new PR is more than welcome :)