Closed Iskustvo closed 1 month ago
Hey @lewis6991, I just retested this with latest changes and there is another issue on step 3.
, basically, just executing
:Gitsigns show HEAD^
echos the following error:
Error executing vim.schedule lua callback: ...gns_test/gitsigns_issue/gitsigns//lua/gitsigns/async.lua:92: attempt to call upvalue 'callback' (a table value)
stack traceback:
...gns_test/gitsigns_issue/gitsigns//lua/gitsigns/async.lua:92: in function 'cb'
...gns_test/gitsigns_issue/gitsigns//lua/gitsigns/async.lua:127: in function <...gns_test/gitsigns_issue/gitsigns//lua/gitsigns/async.lua:126>
Strangely enough, despite the error, everything works as expected in all later steps.
Would you prefer that I close this issue (since it's now solved) and open another one for this error or should I just wait and close this once the show
error is fixed?
Up to you.
Fixed in d9f997d
Retested, everything works, thanks a lot!
Description
After using
Gitsigns show ...
to open specific snapshot of a file,Gitsigns blame_line
doesn't work correctly on that snapshot. It often just pops upNot Committed Yet
window, instead of actually blaming the line.Neovim version
NVIM v0.10.0
Operating system and version
Arch Linux (x86_64) Kernel: 6.9.2-arch1-1
Expected behavior
Gitsigns blame_line
actually blames lines in older file snapshots.Actual behavior
For some lines (both changed and unchanged by current snapshot), it just shows
Not Committed Yet
window, instead of actual commit.Minimal config
Steps to reproduce
Create testing environment
Open test file with minimal Neovim config
Show file snapshot of parent commit (
modify first two lines
)Observe correctly drawn "signs" on first two lines, indicating that this commit really changed the first two lines.
Blame the first line (
aaaa
) in order to see who introduced it.Observe correct popup window claiming that commit
modify first two lines
introduced it.Navigate to second line (
bbbb
) which was introduced by the samemodify first two lines
commit.Blame the second line (
bbbb
) in order to see who introduced it.Observe incorrect
Not Committed Yet
popup, instead ofmodify first two lines
.Navigate to third line (
ccc
) which wasn't modified by this commit.Blame the third line in order to see who introduced it.
Observe incorrect
Not Committed Yet
popup, instead of initial commitadd 3 lines
.Gitsigns debug messages
No response