search

lewis6991 / gitsigns.nvim

Git integration for buffers
MIT License
4.86k stars 186 forks source link

Error when selecting blame actions through popup menu #1061

Closed seblj closed 2 months ago

seblj commented 2 months ago

Description

The blame feature was a really nice attribution to this already wonderful plugin. I am having one minor issue with it though. Selecting the different actions from the popup menu doesn't work for me. Using the built in keybinds r and s does work though. See attached video

https://github.com/lewis6991/gitsigns.nvim/assets/5160701/adf41cbf-ca55-410b-b92a-0d79f450ab03

Neovim version

NVIM v0.11.0-dev-283+gfe5d1279a

Operating system and version

macOS 14.5 (23F79)

Expected behavior

I would expect it to work exactly like pressing r or s without the menu

Actual behavior

I get an error when trying to show the commit, and when trying to reblame, nothing seems to happen

Minimal config

for name, url in pairs{
  gitsigns = 'https://github.com/lewis6991/gitsigns.nvim',
  -- ADD OTHER PLUGINS _NECESSARY_ TO REPRODUCE THE ISSUE
} do
local install_path = vim.fn.fnamemodify('gitsigns_issue/'..name, ':p')
if vim.fn.isdirectory(install_path) == 0 then
vim.fn.system { 'git', 'clone', '--depth=1', url, install_path }
end
vim.opt.runtimepath:append(install_path)
end

require('gitsigns').setup{
  debug_mode = true, -- You must add this to enable debug messages
  -- ADD GITSIGNS CONFIG THAT IS _NECESSARY_ FOR REPRODUCING THE ISSUE
}

-- ADD INIT.LUA SETTINGS THAT IS _NECESSARY_ FOR REPRODUCING THE ISSUE

Steps to reproduce

  1. Add minimal config under ~/.config/gitsigns
  2. Clone gitsigns.nvim repo for using as repo to test out blame
  3. Open neovim with NVIM_APPNAME=gitsigns nvim
  4. Navigate to gitsigns.lua inside repo
  5. Run Gitsigns blame and try to select using enter, navigating in popup menu, and then selecting the actions with enter

Gitsigns debug messages

0.85 D dprintf: Deriving GitSignsAdd from Added                                               
1.12 D derive: Deriving GitSignsChange from Changed                                           
1.24 D derive: Deriving GitSignsDelete from Removed                                           
1.29 D derive: Deriving GitSignsChangedelete from GitSignsChange                              
1.36 D derive: Deriving GitSignsTopdelete from GitSignsDelete                                 
1.39 D derive: Deriving GitSignsUntracked from GitSignsAdd                                    
1.45 D derive: Deriving GitSignsAddNr from GitSignsAdd                                        
1.49 D derive: Deriving GitSignsChangeNr from GitSignsChange                                  
1.53 D derive: Deriving GitSignsDeleteNr from GitSignsDelete                                  
1.57 D derive: Deriving GitSignsChangedeleteNr from GitSignsChangeNr                          
1.61 D derive: Deriving GitSignsTopdeleteNr from GitSignsDeleteNr                             
1.63 D derive: Deriving GitSignsUntrackedNr from GitSignsAddNr 
1.68 D derive: Deriving GitSignsAddLn from DiffAdd                                            
1.73 D derive: Deriving GitSignsChangeLn from DiffChange                                      
1.78 D derive: Deriving GitSignsChangedeleteLn from GitSignsChangeLn                          
1.80 D derive: Deriving GitSignsUntrackedLn from GitSignsAddLn                                
1.82 D derive: Deriving GitSignsStagedAdd from GitSignsAdd                                    
1.85 D derive: Deriving GitSignsStagedChange from GitSignsChange                              
1.88 D derive: Deriving GitSignsStagedDelete from GitSignsDelete                              
1.91 D derive: Deriving GitSignsStagedChangedelete from GitSignsChangedelete                  
1.96 D derive: Deriving GitSignsStagedTopdelete from GitSignsTopdelete                        
2.00 D derive: Deriving GitSignsStagedAddNr from GitSignsAddNr                                
2.03 D derive: Deriving GitSignsStagedChangeNr from GitSignsChangeNr                          
2.06 D derive: Deriving GitSignsStagedDeleteNr from GitSignsDeleteNr                          
2.08 D derive: Deriving GitSignsStagedChangedeleteNr from GitSignsChangedeleteNr              
2.11 D derive: Deriving GitSignsStagedTopdeleteNr from GitSignsTopdeleteNr                    
2.13 D derive: Deriving GitSignsStagedAddLn from GitSignsAddLn                                
2.16 D derive: Deriving GitSignsStagedChangeLn from GitSignsChangeLn                          
2.19 D derive: Could not derive GitSignsStagedDeleteLn                                        
2.21 D derive: Deriving GitSignsStagedChangedeleteLn from GitSignsChangedeleteLn              
2.24 D derive: Could not derive GitSignsStagedTopdeleteLn                                     
2.29 D derive: Deriving GitSignsAddPreview from DiffAdd                                       
2.34 D derive: Deriving GitSignsDeletePreview from DiffDelete                                 
2.37 D derive: Deriving GitSignsCurrentLineBlame from NonText                                 
2.39 D derive: Deriving GitSignsAddInline from TermCursor                                     
2.42 D derive: Deriving GitSignsDeleteInline from TermCursor                                  
2.45 D derive: Deriving GitSignsChangeInline from TermCursor                                  
2.47 D derive: Deriving GitSignsAddLnInline from GitSignsAddInline                            
2.49 D derive: Deriving GitSignsChangeLnInline from GitSignsChangeInline                      
2.52 D derive: Deriving GitSignsDeleteLnInline from GitSignsDeleteInline                      
2.56 D derive: Deriving GitSignsDeleteVirtLn from DiffDelete                                  
2.58 D derive: Deriving GitSignsDeleteVirtLnInLine from GitSignsDeleteLnInline                
2.60 D derive: Deriving GitSignsVirtLnum from GitSignsDeleteVirtLn                            
13.59 D attach(1): Attaching (trigger=BufReadPost)                                            
13.74 D run_job: git --no-pager --no-optional-locks --literal-pathspecs -c gc.auto=0 config us
er.name                                                                                       
29.92 D run_job: git --version                                                                
40.16 D run_job: git --no-pager --no-optional-locks --literal-pathspecs -c gc.auto=0 rev-parse
 --show-toplevel --absolute-git-dir --abbrev-ref HEAD                                         
49.23 D run_job: git --no-pager --no-optional-locks --literal-pathspecs -c gc.auto=0 --git-dir
 /Users/sebastian/gitsigns.nvim/.git -c core.quotepath=off ls-files --stage --others --exclude
-standard --eol /Users/sebastian/gitsigns.nvim/lua/gitsigns.lua                               
59.73 D watch_gitdir(1): Watching git dir                                                     
60.01 D run_job: git --no-pager --no-optional-locks --literal-pathspecs -c gc.auto=0 --git-dir
 /Users/sebastian/gitsigns.nvim/.git show 78a78622167d786e07b13b7ef970032c78907437            
70.30 D run_job: git --no-pager --no-optional-locks --literal-pathspecs -c gc.auto=0 --git-dir
 /Users/sebastian/gitsigns.nvim/.git show HEAD:lua/gitsigns.lua                               
4117.52 D cli.run: Running action 'blame' with arguments {}                                   
4121.14 D run_job: git --no-pager --no-optional-locks --literal-pathspecs -c gc.auto=0 --git-d
ir /Users/sebastian/gitsigns.nvim/.git blame --contents - --incremental -- /Users/sebastian/gi
tsigns.nvim/lua/gitsigns.lua                                                                  
14251.53 D cli.run: Running action 'debug_messages' with arguments {} 


### Gitsigns cache

_No response_