search

lewis6991 / impatient.nvim

Improve startup time for Neovim
MIT License
1.19k stars 28 forks source link

add support for 32bit systems #25

Closed kylo252 closed 3 years ago

kylo252 commented 3 years ago

I tested this on my RPi 4 and it seems to work fine, and it still works on my other 64bit machines.

I'm not all that familiar with luaJIT so hopefully I didn't write something too stupid :)

kylo252 commented 3 years ago

Not sure how to test it with the CI, I saw that it failed on your previous commit as well. I think you're evaluating the SHA before actually switching to it.

lewis6991 commented 3 years ago

The problem is that PRs are being merged In plugins with commits containing old dates messing with the sha querying.

I removed that check, you need to rebase.

kylo252 commented 3 years ago

The problem is that PRs are being merged In plugins with commits containing old dates messing with the sha querying.

Why not pin the specific revision you want? so basically do this earlier:

vim.fn.system{'git', '-C', plugin_dir2, 'checkout', sha} -- rev}

I think you might be able to use the SHA in git clone --branch as well.

lewis6991 commented 3 years ago

Thanks 😄