lewisjdeane / L-Dialogs

A small library replicating the new dialogs in android L.
567 stars 100 forks source link

"Color" spelling #18

Closed 3mph4515 closed 10 years ago

3mph4515 commented 10 years ago

I suppose, that renaming methods titleColor and itemColor to title/itemColour removes backward compatibility with old libs.

StephaneBg commented 10 years ago

We can do that:

    @Deprecated
    public Builder itemColourRes(int _colour) {
        return setItemColorRes(_colour);
    }

    public Builder setItemColorRes(int _color) {
        this.mItemColour = mContext.getResources().getColor(_color);
        return this;
    }
lewisjdeane commented 10 years ago

Sorry but I'm slightly confused by this issue, i've just renamed the methods to color rather than colour, switch to these for future usage.

lewisjdeane commented 10 years ago

I've changed the spelling of the methods than were colour to color, just use these methods instead for now.