search

lewisjdeane / L-Dialogs

A small library replicating the new dialogs in android L.
567 stars 100 forks source link

Custom Views as content (req) #5

Closed gijsdewit closed 10 years ago

gijsdewit commented 10 years ago

Hey, first of all, great lib. I was wondering if it's possible to add custom views to the dialog. I would really like to add images to the dialog. One way of doing that with the default dialogs in Android was to use setView() and set an ImageView, so maybe you can do something similar.

Thanks.

ChrisMCMine commented 10 years ago

That's not possible at the moment

aldefy commented 10 years ago

I have done some experiment , my results are :

device-2014-08-22-160226 device-2014-08-22-160236

device-2014-08-22-160517

device-2014-08-22-160838

device-2014-08-22-160532

aldefy commented 10 years ago

Imageview too :
device-2014-08-22-162643

ChrisMCMine commented 10 years ago

Made a Pull Request: 020692a976bde2975be8a9cad1565584af2bad7f

lewisjdeane commented 10 years ago

This looks good, I'll play around with it soon, got lots of other projects ongoing at the moment but I'll try merge it soon!

lewisjdeane commented 10 years ago

Okay, I've merged the commits, I'll do some further testing to check it works in a broader range of scenarios, thanks everyone for helping with this issue, I don't think I could've managed it myself.