Crash when re-installing a style

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Install a style.
2. Install it again. Click "reinstall."

What is the expected output?

I guess it should re-install it but I don't know what that would actually look 
like from the user's perspective.

What do you see instead?

It crashes. Crash log e-mailed to Chris.

What version of the product are you using? On what operating system?

1.3.0b4, 10.7.x

Original issue reported on code.google.com by rgovostes on 26 Sep 2011 at 4:41

[GoogleCodeExporter]

Original comment by ch...@growl.info on 26 Sep 2011 at 4:44

• Added labels: Milestone-1.3.1, Product-Growl

[GoogleCodeExporter]

Tried reproducing this in the most current source build, and I could not repro. 
Daniel also tried to repro it and he could not get it to crash. I think this is 
resolved. We will leave it open to confirm against the final release before 
closing.

Original comment by ch...@growl.info on 26 Sep 2011 at 8:03

[GoogleCodeExporter]

who put rgov on the beta list? clearly a mistake!

Original comment by rarich...@gmail.com on 26 Sep 2011 at 4:16

[GoogleCodeExporter]

Is this still happening for you in 1.3 rgov?

Original comment by ch...@growl.info on 10 Oct 2011 at 2:18

• Changed state: WaitingOnUser

[GoogleCodeExporter]

No, I tried it a bunch of times but I couldn't get it to happen. A few comments 
though:

1. It's not showing up in the "display styles" list the instant I install it, I 
have to quit the Growl app and relaunch.

2. I managed to somehow get it to show the same style twice. I think I did this 
by quitting Growl then trying to install a style that was already installed.

3. The "Yes" and "No" buttons on the "Do you want to reinstall it?" and 
"Configure now?" dialogs violate HIG.

Original comment by rgovostes on 10 Oct 2011 at 5:43

[GoogleCodeExporter]

1 is covered by #290
2 is covered by #270

3. the HIG would actually disagree with you.  it says to avoid using OK for the 
default button and to use language the user understands. "do you want to 
reinstall it?" yes and no are perfectly valid responses to that question, same 
for configure now.

"Ensure that the default button name corresponds to the action you describe. In 
particular, it’s a good idea to avoid using OK for the default button. The 
meaning of OK can be unclear even in alerts that ask if the user is sure they 
want to do something. For example, does OK mean “OK, I want to complete the 
action” or “OK, I now understand the negative results my action would have 
caused”?

Using a more focused button name, such as Erase, Convert, Clear, or Delete, 
helps make sure that users understand the action they’re taking."

Original comment by rarich...@gmail.com on 10 Oct 2011 at 6:09

[GoogleCodeExporter]

Original comment by rarich...@gmail.com on 10 Oct 2011 at 6:11

• Changed state: Fixed

[GoogleCodeExporter]

While I agree "Yes" and "No" are language the user understands, the last 
sentence you pasted, about using "more focused button names," seems to go along 
with what I was saying: "Reinstall" and "Cancel" seem better than "Yes" and 
"No", since they don't require me to carefully read the whole dialog.

But that's a bit off-topic from this issue!

Original comment by rgovostes on 10 Oct 2011 at 6:27

[GoogleCodeExporter]

File a separate ticket on that rgov :)

Original comment by ch...@growl.info on 10 Oct 2011 at 7:04