search

lewisje / ourlibrary

Automatically exported from code.google.com/p/ourlibrary
0 stars 0 forks source link

toggle and togglePresence methods (E and Q) have wrong signature #20

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
They aren't supposed to have - b - arguments of course.  Those are from the 
corresponding - show - method signatures. Looks like a copy and paste 
mistake from way back.

Fix will be in the next update.  Sorry for any inconvenience.

As an aside, the use of toggle* is advised against.  Same as I would advise 
against a toggleClass function (though will put one in if asked).  Your app 
should keep track of whether it wants to show or hide the element.  Any 
reliance on computing styles to determine whether to show or hide an element 
complicates what should be (and often needs to be) a trivial matter.  If you 
want to support agents that do not compute styles (or do it poorly), you 
have to remember to set the inline display style.

Original issue reported on code.google.com by dmark.ci...@gmail.com on 20 Apr 2010 at 12:55