lewisje / ourlibrary

Automatically exported from code.google.com/p/ourlibrary
0 stars 0 forks source link

unnecessary request for docs/c.html #7

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. add mylib.js to a page
2. load the page and watch the network

What is the expected output? What do you see instead?
I expect a single request for mylib.js. Instead I see a request for mylib.js 
and docs/c.html.

What version of the product are you using? On what operating system?
Sun, 28 Mar 2010 22:49:28 UTC

Original issue reported on code.google.com by johnm...@gmail.com on 29 Mar 2010 at 2:02

GoogleCodeExporter commented 9 years ago
That's a side effect of the feature testing for getAttributeProperty, which was 
recently copied over from here:-

http://www.cinsoft.net/attributes.html

...and I should have paid a little more attention to what I was copying.

Why I chose such an odd path for that test is something long forgotten.  I will 
defer that test (and it may never run, depending on your app) on the next 
update 
(tomorrow) and add a property so you can specify a dummy resource (to avoid an 
error 
in your server logs).

Original comment by dmark.ci...@gmail.com on 29 Mar 2010 at 3:00

GoogleCodeExporter commented 9 years ago

Original comment by dmark.ci...@gmail.com on 29 Mar 2010 at 5:15

GoogleCodeExporter commented 9 years ago
Would the test work equally well with a request for /favicon.ico? Most pages 
would either already have it or 
already be getting errors in their logs from the browsers insistence on 
automatically loading it; and since the 
browsers are already requesting it no secondary request would be necessary for 
the test.

Original comment by johnm...@gmail.com on 29 Mar 2010 at 5:12

GoogleCodeExporter commented 9 years ago
That's the perfect solution!

Thanks and will do that in the next update (up in a few hours after I finish my 
stress 
tests).

Original comment by dmark.ci...@gmail.com on 29 Mar 2010 at 5:20

GoogleCodeExporter commented 9 years ago
Changed to use /favicon.ico.  Thanks John!

Original comment by dmark.ci...@gmail.com on 29 Mar 2010 at 9:10