search

lewisje / svgweb

Automatically exported from code.google.com/p/svgweb
Other
0 stars 0 forks source link

Incorrect browser detection for Firefox-like browsers #562

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
The browser detection logic in SVGWeb looks for "Firefox/" in the User-Agent 
string in order to decide whether to activate certain special hacks.  This is 
wrong; it will cause SVGWeb to malfunction on browsers such as Seamonkey, 
Camino, etc. that use Firefox's rendering engine but are not actually Firefox.  
You should look only for "Gecko" in the User-Agent.

Suggested patch to svg-uncompressed.js attached.

Original issue reported on code.google.com by zack.weinberg on 19 Oct 2010 at 10:47

Attachments:

GoogleCodeExporter commented 8 years ago 
Our browser detection is taken from Dojo, so it looks like a bug there. Thanks 
for the patch! We need to refactor our browser and feature detection in general 
(issue 572).

Original comment by bradneub...@gmail.com on 16 Nov 2010 at 10:12