search

lewissbaker / cppcoro

A library of C++ coroutine abstractions for the coroutines TS
MIT License
3.36k stars 462 forks source link

change doctest to always include <ostream> #175

Closed andreasbuhr closed 3 years ago

andreasbuhr commented 3 years ago

On MSVC 1928, doctest.h fails to compile if was not included before. In the code was a statement that a similar problem existed with clang before. This patch changes doctest.h to always include .

andreasbuhr commented 3 years ago

I agree. Updating doctest is better than patching the old one. I created a pull request for this in https://github.com/lewissbaker/cppcoro/pull/178 but that still needs more testing.