References to absolute paths (C:/) found in code?

lewiz-support / LMAC_CORE2

LeWiz Communications Ethernet MAC Core2 10G/5G/2.5G/1G

30 stars 12 forks source link

References to absolute paths (C:/) found in code? #1

Closed mithro closed 5 years ago

mithro commented 5 years ago

The code has absolute paths in it, these are not great because;

Linux and Windows have different concepts of the best absolute path
Code needs to be at a given location to work correctly.

Here are some examples; https://github.com/lewiz-support/LMAC_CORE2/blob/79507233b7e084b7c596035d053ee5277c638ba6/LMAC2_INFO/PHY_EMULATOR/phy_emulator_10G.v#L141-L142

lewiz-support commented 5 years ago

These paths are consistent with the project file and instructions provided with the core. This way the user does not need to change anything and can get up and running quickly. We welcome contribution from the community for relative path version. Please provide appropriate instructions if you do make the changes.