icons overridden by extensions that contribute language icons

lewxdev / vscode-glyph

A minimal icon theme for vscode inspired by Spectrum Icons by @alexperronnet

https://marketplace.visualstudio.com/items?itemName=lewxdev.vscode-glyph

MIT License

6 stars 0 forks source link

icons overridden by extensions that contribute language icons #10

Open kimagin opened 3 months ago

kimagin commented 3 months ago

Thank you very much for the beautiful Icons.

While, everything looks elegance, the .astro file icons appear in color and they become distracting.

Thank you for your attention to this issue.

lewxdev commented 2 months ago

@kimagin thanks for submitting this issue. I noticed this too, but I'm not sure the best way to resolve it.

it seems like this happens when extensions that add contributes.languages[].icon seem to override the icon theme (in this case Astro). is this what you're seeing? I also noticed this with Cucumber (Gherkin) Full Support for .feature files

kimagin commented 2 months ago

Hello,

I've tried my self to find the JSON file containing all the Icon sets inside the extension folder and added a new .astro to the object. Then I've used a black and white version of Astro icon from Iconify and added it to the JSON object and it worked fine. Having said that, this should be implemented from your side, otherwise every time that I install the extension, I have to do it manually. Hope this will be helpful.

lewxdev commented 2 months ago

kicking myself for just discovering "showLanguageModeIcons":false. @kimagin, this should be fixed next release 🙌🏽