Closed audsssy closed 2 years ago
@audsssy is attempting to deploy a commit to the LexDAO Team on Vercel.
A member of the Team first needs to authorize it.
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/lexdao/kali/F8kycDkzqxWYkEHUzH7yob65SRrp
✅ Preview: https://kali-git-fork-audsssy-nit-permit-test-lexdao.vercel.app
good stuff @audsssy why do we think incrementing the nonce outside of digest provides fix here? *Edit -- Also, it is quite strange for test to execute permit, but yet also produce revert.
Update: Looks like the error was a result of unmatched function name between
(1)
and
(2)
Once PERMIT_TYPEHASH
in (1) is updated to Permit
to match that in (2), the error goes away!
Update: Looks like the error was a result of unmatched function name between
(1)
and
(2)
Once PERMIT_TYPEHASH
in (1) is updated to Permit
to match that in (2), the error goes away!
Woot. Thanks for the review and merge!
Context
permit should work if the signature is valid
test throws InvalidSignature() via subtext even though it passes test (see below).. not sure why it passes in the first placeKaliDAOtoken.sol- Update input parameter todigest
in permit() asnonces[owner]++
throws InvalidSignature()KaliDAO.test.js