search

lexanth / testing-library-table-queries

Additional testing-library queries for querying tables like a user
19 stars 3 forks source link

allow wrapped text in first cells and column headers #12

Closed luchsamapparat closed 3 years ago

luchsamapparat commented 3 years ago

Hi,

thanks for providing this library!

I ran into an issue with table head cells that wrapped the text content in some div elements.

Retrieving the text of a cell via getNodeText only works if the text is a direct child of the cell node. Retrieving the text using textContent also returns text wrapped in child elements.

At first sight I don't see any significant downsides to using textContent directly and it would solve the issue with wrapped text which probably isn't too unusual.

luchsamapparat commented 3 years ago

Hi @lexanth

thanks for merging! Any estimation when you'll be able to release a new version?

lexanth commented 3 years ago

@luchsamapparat Sorry about the delay! Published now.

luchsamapparat commented 3 years ago

No problem, thank you!