New CSS selector ":contains(text)"

[f34nk]

Hey Alex, I followed your instructions in #36 and added new pseudo class "contains".

• added "contains" to $func_map = {...}
• run script perl utils/MyCSS/functions.pl
• added all "contains" related functions and enums
• function mycss_selectors_function_begin_contains() in file function.c: added selector sub_type MyCSS_SELECTORS_SUB_TYPE_PSEUDO_CLASS_FUNCTION_CONTAINS
• added test test/myhtml/pseudo_class_contains.c
• implemented finder function in modest_finder_selector_sub_type_pseudo_class_function_contains() in file pseudo_class.c.

As of now, the selector argument cannot contain single or double quotation marks. That's because I basically duplicated the implementation from pseudo class "has", so behavior and serialization is the same.

Example:

const char *selector = ":contains(Hello)"; // works
const char *selector = ":contains('Hello')"; // Bad Selector
const char *selector = ":contains(\"Hello\")"; // Bad Selector

According to the spec (from 2001) however, quotation marks should also be supported.

The :contains("foo") pseudo-class notation represents an element whose textual contents contain the given substring. The argument of this pseudo-class can be a string (surrounded by double quotes) or a keyword.

So my implementation only solves the "argument as keyword" case. Tell me what you think.

Best, Frank

[lexborisov]

AWESOME!

[f34nk]

Thanks man! That was fun :)

[lexborisov]

You're welcome! 😄