search

lexeme-dev / core

A project to develop novel algorithms and analysis techniques for legal research
4 stars 0 forks source link

Add ParentheticalProcessor for identifying descriptive parentheticals #75

Closed ProbablyFaiz closed 2 years ago

varun-magesh commented 2 years ago

v minor but I don't think we should use a class as namespace here when the file already is one --- but this may be a difference between us and it certainly shouldn't hold up merging.

ProbablyFaiz commented 2 years ago

v minor but I don't think we should use a class as namespace here when the file already is one --- but this may be a difference between us and it certainly shouldn't hold up merging.

Yeah... I've kind of abused that pattern throughout this codebase. The reason being is that lots of our classes depend on being initialized with some singleton object (e.g. CitationNetwork) that they can use to do their necessary calculations efficiently. That's not the case for this one but I think it's worth doing here anyway for consistency's sake.