search

lexi-lambda / freer-simple

A friendly effect system for Haskell
https://hackage.haskell.org/package/freer-simple
BSD 3-Clause "New" or "Revised" License
228 stars 20 forks source link

Allow template-haskell 2.17, 2.18 #34

Closed sorki closed 2 years ago

sorki commented 3 years ago

With a bit of CPP for backwards compatibility.

Ref https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.0#template-haskell-217

jchia commented 3 years ago

I was just about to submit a PR, word-for-word the same as this one except for one type variable name.

@sorki I just did some tests and found that the template-haskell-2.18.0.0 also works so the upper bound can be bumped further: - template-haskell >= 2.11 && < 2.19 This would allow freer-simple to work with the latest version of template-haskell.

@lexi-lambda Could you please process this PR and make a new hackage release if it looks good? It is needed for GHC 9.0.

sorki commented 3 years ago

I was just about to submit a PR, word-for-word the same as this one except for one type variable name.

@sorki I just did some tests and found that the template-haskell-2.18.0.0 also works so the upper bound can be bumped further: - template-haskell >= 2.11 && < 2.19 This would allow freer-simple to work with the latest version of template-haskell.

Nice! I've bumped the bound to allow 2.18 as well.

lexi-lambda commented 2 years ago

Thanks, and sorry about the delay.

lexi-lambda commented 2 years ago

I’ve now released this to Hackage as freer-simple-1.2.1.2.